clayborg added inline comments.
================ Comment at: include/lldb/Breakpoint/BreakpointSiteList.h:130 + using ModifyingCallback = std::function<bool(BreakpointSite &)>; + bool ForEach(const ModifyingCallback &callback); ---------------- I was a bit vague with my explanations. Only ModifyingCallback needs to return a bool. No need for the ForEach function itself to return a bool, just the callback. ================ Comment at: include/lldb/Breakpoint/BreakpointSiteList.h:133 + using Callback = std::function<bool(const BreakpointSite &)>; + bool ForEach(const Callback &callback) const; + ---------------- Ditto, no need to return bool from ForEach. https://reviews.llvm.org/D39967 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
