labath added inline comments.

================
Comment at: CMakeLists.txt:73-80
+  if ("${LLDB_TEST_C_COMPILER}" STREQUAL "")
+    set(LLDB_TESTING_DEFAULT_C_COMPILER ON)
+  endif()
+
+  if ("${LLDB_TEST_CXX_COMPILER}" STREQUAL "")
+    set(LLDB_TESTING_DEFAULT_CXX_COMPILER ON)
+  endif()
----------------
I don't think this will work the second time you run cmake (i.e., re-run cmake 
in an already-initialized build directory) as then this would pick up the 
cached value from the previous cmake run.

I think a least magic solution would be to have a cmake option to specify 
whether you are overriding the compiler, defaulting to off (and in that case 
these cache values would be ignored).



https://reviews.llvm.org/D43096



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to