aprantl added inline comments.
================
Comment at: packages/Python/lldbsuite/test/api/listeners/TestListener.py:26
TestBase.setUp(self)
- self.build()
----------------
labath wrote:
> I'm confused by these changes. I was under the impression that setUp() runs
> before each test method (and hence this should be NFC). Can you explain the
> reasoning behind this?
(see also my previous comment)
`setUp` runs before everything else, but it runs once per testcase and
`self.testMethodName` is not initialized yet. Therefore we can only run
`self.build()` in `self.setUp()` in NO_DEBUG_INFO_TESTCASEs.
https://reviews.llvm.org/D42763
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits