The comments were automatically added a long time ago when I tried to run IWYU on LLDB source code. I don't think you need to maintain them.
On Sat, Jan 20, 2018 at 2:25 PM Raphael Isemann via Phabricator via lldb-commits <lldb-commits@lists.llvm.org> wrote: > teemperor created this revision. > teemperor added a reviewer: aprantl. > > This patch adds missing includes to the LLDB headers inside `include/` as > a first step of building LLDB's source with C++ modules. Includes in lldb > seem to be commented if the reason for the include is not obvious (`// for > addr_t`), so I tried to keep the same style here. It also fixes this single > `stds::` typo. > > > https://reviews.llvm.org/D42340 > > Files: > include/lldb/Core/LoadedModuleInfoList.h > include/lldb/Core/ThreadSafeDenseSet.h > include/lldb/Core/ThreadSafeValue.h > include/lldb/DataFormatters/VectorIterator.h > include/lldb/Target/ProcessStructReader.h > include/lldb/Utility/AnsiTerminal.h > include/lldb/Utility/SharedCluster.h > > > Index: include/lldb/Utility/SharedCluster.h > =================================================================== > --- include/lldb/Utility/SharedCluster.h > +++ include/lldb/Utility/SharedCluster.h > @@ -15,6 +15,8 @@ > > #include "llvm/ADT/SmallPtrSet.h" > > +#include <mutex> > + > namespace lldb_private { > > namespace imp { > Index: include/lldb/Utility/AnsiTerminal.h > =================================================================== > --- include/lldb/Utility/AnsiTerminal.h > +++ include/lldb/Utility/AnsiTerminal.h > @@ -50,6 +50,7 @@ > #define ANSI_1_CTRL(ctrl1) "\033["##ctrl1 ANSI_ESC_END > #define ANSI_2_CTRL(ctrl1, ctrl2) "\033["##ctrl1 ";"##ctrl2 ANSI_ESC_END > > +#include "llvm/ADT/ArrayRef.h" > #include "llvm/ADT/STLExtras.h" > #include "llvm/ADT/StringRef.h" > > Index: include/lldb/Target/ProcessStructReader.h > =================================================================== > --- include/lldb/Target/ProcessStructReader.h > +++ include/lldb/Target/ProcessStructReader.h > @@ -16,6 +16,7 @@ > #include "lldb/Symbol/CompilerType.h" > #include "lldb/Target/Process.h" > #include "lldb/Utility/ConstString.h" > +#include "lldb/Utility/DataBufferHeap.h" > #include "lldb/Utility/DataExtractor.h" > #include "lldb/Utility/Status.h" > > Index: include/lldb/DataFormatters/VectorIterator.h > =================================================================== > --- include/lldb/DataFormatters/VectorIterator.h > +++ include/lldb/DataFormatters/VectorIterator.h > @@ -13,6 +13,7 @@ > > #include "lldb/lldb-forward.h" > > +#include "lldb/DataFormatters/TypeSynthetic.h" // for > SyntheticChildrenFrontEnd > #include "lldb/Target/ExecutionContext.h" > #include "lldb/Utility/ConstString.h" > > Index: include/lldb/Core/ThreadSafeValue.h > =================================================================== > --- include/lldb/Core/ThreadSafeValue.h > +++ include/lldb/Core/ThreadSafeValue.h > @@ -17,6 +17,7 @@ > > // Other libraries and framework includes > // Project includes > +#include "lldb/lldb-defines.h" // for DISALLOW_COPY_AND_ASSIGN > > namespace lldb_private { > > Index: include/lldb/Core/ThreadSafeDenseSet.h > =================================================================== > --- include/lldb/Core/ThreadSafeDenseSet.h > +++ include/lldb/Core/ThreadSafeDenseSet.h > @@ -46,7 +46,7 @@ > } > > void Clear() { > - stds::lock_guard<_MutexType> guard(m_mutex); > + std::lock_guard<_MutexType> guard(m_mutex); > m_set.clear(); > } > > Index: include/lldb/Core/LoadedModuleInfoList.h > =================================================================== > --- include/lldb/Core/LoadedModuleInfoList.h > +++ include/lldb/Core/LoadedModuleInfoList.h > @@ -13,10 +13,13 @@ > // C Includes > > // C++ Includes > +#include <cassert> > #include <vector> > > // Other libraries and framework includes > +#include "lldb/lldb-defines.h" // for LLDB_INVALID_ADDRESS > #include "lldb/lldb-private-forward.h" > +#include "lldb/lldb-types.h" // for addr_t > > namespace lldb_private { > class LoadedModuleInfoList { > > > _______________________________________________ > lldb-commits mailing list > lldb-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
