zturner added inline comments.
================
Comment at: include/lldb/Utility/Environment.h:70-72
+ std::pair<iterator, bool> insert(llvm::StringRef KeyEqValue) {
+ return insert(KeyEqValue.split('='));
+ }
----------------
Why'd you decide to go with inserting an entire pre-formatted key value pair in
the form `{key}={value}`, instead of having the function be `insert(StringRef
Key, StringRef Value)`?
================
Comment at: source/Host/macosx/Host.mm:763
- proc_env.AppendArgument(llvm::StringRef(cstr));
+ proc_env.insert(cstr);
}
----------------
Indentation is messed up here.
https://reviews.llvm.org/D41359
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
