> On Dec 11, 2017, at 10:25 AM, Zachary Turner <ztur...@google.com> wrote:
> 
> What about adding GetMemorySize?

We already have that as Section::GetByteSize().


> On Mon, Dec 11, 2017 at 10:23 AM Greg Clayton via Phabricator 
> <revi...@reviews.llvm.org <mailto:revi...@reviews.llvm.org>> wrote:
> clayborg added a comment.
> 
> I think GetFileSize() should remain the number of bytes of the section on 
> disk and we should add new API if we need to figure out the decompressed 
> size. Or maybe when we get bytes from a compressed section we are expected to 
> always just get the raw bytes, then we check of the section is compressed, 
> and if so, then we call another API on ObjectFile to decompress the data. So 
> I would prefer GetFileSize() to return the file size of the section size in 
> the file and not the decompressed size. Is there a way to make this work?
> 
> 
> https://reviews.llvm.org/D40616 <https://reviews.llvm.org/D40616>
> 
> 
> 

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to