As an aside, I don't really like this class. For example, You can currently assign a UUID[16] to a UUID[20]. That doesn't make a lot of sense to me.
As a future cleanup, I think this class should probably be a template such as UUID<N>, and then internally it can store a std::array<uint8_t, N>. And we can static_assert that N is of a known size if we desire. On Mon, Nov 27, 2017 at 9:38 PM Davide Italiano via Phabricator < revi...@reviews.llvm.org> wrote: > davide added a comment. > > Yes, what Zachary said. Thanks for the cleanup. There's a decent amount of > code in lldb that can be written in a very compact way but it's manually > unrolled. I think in this case the code produced should be equivalent (and > if not, I'd be curious to see the codegen). > More generally, whenever a function is not in a hot loop, we might > consider preferring readability over performances anyway. > > > https://reviews.llvm.org/D40537 > > > >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
