emaste accepted this revision.
emaste added a comment.
This revision is now accepted and ready to land.
Still would appreciate diffs uploaded with full context - i.e.,
Note that you can upload patches created through various diff tools,
including git and svn. To make reviews easier, please always include as much
context as possible with your diff! Don’t worry, Phabricator will automatically
send a diff with a smaller context in the review email, but having the full
file in the web interface will help the reviewer understand your code.
To get a full diff, use one of the following commands (or just use Arcanist
to upload your patch):
git show HEAD -U999999 > mypatch.patch
git format-patch -U999999 @{u}
svn diff --diff-cmd=diff -x -U999999
However, patch looks good to me.
Repository:
rL LLVM
https://reviews.llvm.org/D35223
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
