labath accepted this revision. labath added a comment. The test looks well written. I've added a couple of suggestions you can consider including.
================ Comment at: packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/TestBreakpointHitCount.py:15 + + mydir = TestBase.compute_mydir(__file__) + ---------------- You may want to add `NO_DEBUG_INFO_TESTCASE = True` here to turn off magic test duplication. ================ Comment at: packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/TestBreakpointHitCount.py:105 + self.assertTrue(location1.GetHitCount() == 1) + self.assertTrue(breakpoint.GetHitCount() == 3) + ---------------- using `assertEqual` will give more meaningful error messages in case this ever breaks. https://reviews.llvm.org/D31283 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
