penryu added a comment.

Thanks, sas.

I'll be honest, my prefer solution involves an inlined function (uint64_t -> 
TypeCodes) that eliminates the cast from the NSNumberSummaryProvider() method 
altogether. This way we can handle any dirty mappings from raw memory directory 
to the enum within the one function, and take advantage of the compiler's 
exhaustiveness check to ensure we're covering our bases.

I'll ponder a bit and consider reworking this patch in that form.


https://reviews.llvm.org/D35036



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to