clayborg added a comment.
I would think we would try to enable this using something like:
QEnableErrorStrings
And if the the server responds with "OK" then we know it is enabled. By default
the server should not enable any fancy features without being asked. We would
like lldb-server to stay compatible with other GDB remote clients.
The error string should be hex ASCII encoded so the string can contain any
characters. Any string that can contain any content should be hex ASCII encoded.
================
Comment at: docs/lldb-gdb-remote.txt:137
+//
+// E<error code>;"Error Message"
+//
----------------
labath wrote:
> The quotes here are misleading -- after reading this I would expect that the
> string is sent quoted. Best be explicit about the encoding of the error
> string.
Maybe:
```
EXX;AAAAAA
Where XX is a hex byte error number, followed by a semicolon and where AAAAAA
is a hex ascii encoded error message.
```
================
Comment at: docs/lldb-gdb-remote.txt:276
send packet: jTraceStart:{"type":<type>,"buffersize":<buffersize>}]
-read packet: <trace id>/E<error code>
+read packet: <trace id>/E<error code>;"Error Message"
----------------
Just make similar to whatever we decide on in the docs for
QErrorStringInPacketSupported
================
Comment at: docs/lldb-gdb-remote.txt:310
send packet: jTraceStop:{"traceid":<trace id>}]
-read packet: <OK response>/E<error code>
+read packet: <OK response>/E<error code>;"Error Message"
----------------
Just make similar to whatever we decide on in the docs for
QErrorStringInPacketSupported
================
Comment at: docs/lldb-gdb-remote.txt:343
send packet: jTraceBufferRead:{"traceid":<trace
id>,"offset":<byteoffset>,"buffersize":<byte_count>}]
-read packet: <binary trace data>/E<error code>
+read packet: <binary trace data>/E<error code>;"Error Message"
----------------
Just make similar to whatever we decide on in the docs for
QErrorStringInPacketSupported
================
Comment at: docs/lldb-gdb-remote.txt:385
send packet: jTraceConfigRead:{"traceid":<trace id>}
-read packet:
{"conf1":<conf1>,"conf2":<conf2>,"params":{"paramName":paramValue}]}];/E<error
code>
+read packet:
{"conf1":<conf1>,"conf2":<conf2>,"params":{"paramName":paramValue}]}];/E<error
code>;"Error Message"
----------------
Just make similar to whatever we decide on in the docs for
QErrorStringInPacketSupported
https://reviews.llvm.org/D34945
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
