eugene accepted this revision.
eugene added a comment.
This revision is now accepted and ready to land.

Great change. The only comment I have is about location of TestUtilities.cpp.
Utility\Helpers kinda implies that these are helpers for Utility tests which is 
not true.

I would move it up one level up lldb/unittests/TestUtilities.cpp


https://reviews.llvm.org/D34683



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to