labath marked 2 inline comments as done.
labath added inline comments.
================
Comment at: source/Host/common/Host.cpp:1010
+ static constexpr char type[] = "WXS";
+ OS << formatv("{0}{1:x-2}", type[WS.type], WS.status);
+ return;
----------------
eugene wrote:
> type[WS.type] seems to be a somewhat unnecessary hack. I would use a simple
> switch here.
I wouldn't call it a hack. :) More like data-oriented programming... :P
I wrote it like this because fully
clang-formatted
switches
tend
to
be
loooooong
.
But I don't care about it too much.
https://reviews.llvm.org/D33998
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
