labath added a comment.

In https://reviews.llvm.org/D33426#772174, @bgianfo wrote:

> @jingham @labath do you have any more feedback?


As Jim pointed out, the Resume command does not do what I thought it does, so 
having it in the test makes no sense. One option would be to just leave out the 
calls to Resume (as they don't do anything anyway) and go with your workaround 
of testing the threads that happened to stop at the breakpoint on the first 
run. The other option would be to replace the Resume call with something that 
does what we intended (one such candidate would be thread.StepOut). I prefer 
the second one as it gives a more deterministic output, but I think both of 
them are good enough.


https://reviews.llvm.org/D33426



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to