beanz added inline comments.
================
Comment at: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py:1418
"include")),
- 'LD_EXTRAS': "-L%s -llldb" % lib_dir}
+ 'LD_EXTRAS': "-L%s/../lib -llldb -Wl,-rpath,%s/../lib" %
(lib_dir, lib_dir)}
elif sys.platform.startswith('win'):
----------------
fjricci wrote:
> Why do we need to make this `-L$(lib_dir)/../lib` instead of the original
> `-L$(lib_dir)`? This breaks cases where `lib_dir` is `lib64` and not `lib`
Basically because this is hack on top of hack on top of hack...
Confusingly `lib_dir` is actually set to the `bin` dir not the correct setting
for `lib`/`lib64`. Except if lldb supports the `-P` flag, and your host is
FreeBSD or Linux, in which case we construct the lib path from the python
path...
So this change was needed to make Darwin or NetBSD work, but broke FreeBSD and
Linux in lib64 configurations... great...
We *really* need to clean up all of this because the garbled mess of
platform-specific hacks is a really big problem.
Repository:
rL LLVM
https://reviews.llvm.org/D25886
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
