llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Stefan Gränitz (weliveindetail) <details> <summary>Changes</summary> Attempt to fix forward a test failure after https://github.com/llvm/llvm-project/pull/183302, which seems to be caused by reusing build directories for test inferiors in LLDB API tests. --- Full diff: https://github.com/llvm/llvm-project/pull/185004.diff 2 Files Affected: - (modified) lldb/test/API/symstore/Makefile (-2) - (modified) lldb/test/API/symstore/TestSymStoreLocal.py (+3-4) ``````````diff diff --git a/lldb/test/API/symstore/Makefile b/lldb/test/API/symstore/Makefile index 6279aee698dad..c9319d6e6888a 100644 --- a/lldb/test/API/symstore/Makefile +++ b/lldb/test/API/symstore/Makefile @@ -1,4 +1,2 @@ -MAKE_PDB := YES - C_SOURCES := main.c include Makefile.rules diff --git a/lldb/test/API/symstore/TestSymStoreLocal.py b/lldb/test/API/symstore/TestSymStoreLocal.py index f45e368613847..154af876fea3f 100644 --- a/lldb/test/API/symstore/TestSymStoreLocal.py +++ b/lldb/test/API/symstore/TestSymStoreLocal.py @@ -71,12 +71,11 @@ class SymStoreLocalTests(TestBase): TEST_WITH_PDB_DEBUG_INFO = True def build_inferior(self): + if self.getDebugInfo() != "pdb": + self.skipTest("Non-PDB debug info variants not yet supported") self.build() exe_file = "a.out" - if self.getDebugInfo() == "pdb": - sym_file = "a.pdb" - else: - self.skipTest("Non-PDB debug info variants not yet supported") + sym_file = "a.pdb" self.assertTrue(os.path.isfile(self.getBuildArtifact(exe_file))) self.assertTrue(os.path.isfile(self.getBuildArtifact(sym_file))) return exe_file, sym_file `````````` </details> https://github.com/llvm/llvm-project/pull/185004 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
