================
@@ -90,6 +126,26 @@ void ProcessFreeBSDKernelCore::RefreshStateAfterStop() {
}
}
+size_t ProcessFreeBSDKernelCore::DoWriteMemory(lldb::addr_t addr,
+ const void *buf, size_t size,
+ Status &error) {
+ if (GetGlobalPluginProperties().GetReadOnly()) {
+ error = Status::FromErrorString(
+ "Memory writes are disabled in read-only mode. Disable with 'settings "
+ "set plugin.process.freebsd-kernel-core.read-only false'");
----------------
DavidSpickett wrote:
This phrasing is a bit confusing. It's not awful by any means but we can do a
better job.
* You say "read-only mode" but this is not a general concept or noun that would
help any user find out what to do. It's not something they can search and find
anything other than this error message. I would not mention modes at all here.
* Saying "disable" twice is confusing at first because it can be read as if the
second disable refers to memory writes. You mean disable the mode, but it's not
100% clear at a glance that that's the case. And once we remove the "mode"
mention, this is academic anyway.
So I suggest instead:
Memory writes are currently disabled. You can enable them with `set
plugin.process.freebsd-kernel-core.read-only false`.
https://github.com/llvm/llvm-project/pull/183237
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
