================
@@ -1465,6 +1465,101 @@ bool 
DisassemblerLLVMC::MCDisasmInstance::IsAuthenticated(
   return InstrDesc.isAuthenticated() || IsBrkC47x;
 }
 
+static void
+UpdateSubtargetFeatures(const llvm::SubtargetFeatures &subtarget_features,
+                        std::string &user_feature_overrides) {
----------------
santhoshe447 wrote:

If felt it was a good choice to avoid multiple copies, since` features_str` is 
used after calling.
`UpdateSubtargetFeatures(subtarget_features, features_str);`

```
  /// This function merges the user overwrite features (provided via -Y option)
  /// with the subtarget features retrieved from the ELF. It also validates the
  /// user overwrite feature string and only valid flags are included in the
  /// final feature string.
  /// \param[in] subtarget_features
  ///     Sub-target feature string retrieved from ELF attributes.
  /// \param[in,out] subtarget_features
  ///     The feature string contains the user-specified overrides, on
  ///     return, this string updated to contain the fully merged and validated
  ///     feature string.
  static void UpdateSubtargetFeatures(const llvm::StringRef &subtarget_features,
                                      std::string &user_feature_overrides);
```
I will change if it's incorrect.

https://github.com/llvm/llvm-project/pull/147990
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to