================
@@ -1465,6 +1465,101 @@ bool
DisassemblerLLVMC::MCDisasmInstance::IsAuthenticated(
return InstrDesc.isAuthenticated() || IsBrkC47x;
}
+static void
+UpdateSubtargetFeatures(const llvm::SubtargetFeatures &subtarget_features,
+ std::string &user_feature_overrides) {
----------------
lenary wrote:
I don't think I understand this function from first looking at its arguments:
`user_feature_overrides` is an input and an output, and will be changed? That's
not obvious at all.
Conceptually, this function isn't returning "user feature overrides", right?
User feature overrides are an input, and the thing this function produces are a
set of features to disassemble with. This is not at all clear from the
signature.
https://github.com/llvm/llvm-project/pull/147990
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
