Author: Omair Javaid Date: 2026-02-19T17:17:53+05:00 New Revision: bca95d1e4dd4339609431da2342c8a46590df7fa
URL: https://github.com/llvm/llvm-project/commit/bca95d1e4dd4339609431da2342c8a46590df7fa DIFF: https://github.com/llvm/llvm-project/commit/bca95d1e4dd4339609431da2342c8a46590df7fa.diff LOG: Disable shared builds for tests failing on Windows (#182249) PR #181720 introduced shared builds for LLDB API tests to improve test efficiency. But several data formatter tests requiring PDB debug info are failing on Windows x64 and AArch64 platforms. This patch disables shared builds for these tests by setting SHARED_BUILD_TESTCASE = False The shared build optimization breaks these tests because they reuse build artifacts between test methods The test runs may could use multiple methods with different debug formats or compiler flags. When a test runs first it builds with one set of flags, but then it runs again but **make** sees the source unchanged so it skips rebuilding and reuses the same old binary instead of rebuilding with correct flags. Added: Modified: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/optional/TestDataFormatterGenericOptional.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/shared_ptr/TestDataFormatterStdSharedPtr.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/span/TestDataFormatterStdSpan.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/string_view/TestDataFormatterStdStringView.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/u8string/TestDataFormatterStdU8String.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/u8string_view/TestDataFormatterStdU8StringView.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/unique_ptr/TestDataFormatterStdUniquePtr.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/unordered/TestDataFormatterGenericUnordered.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/variant/TestDataFormatterStdVariant.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vector/TestDataFormatterStdVector.py lldb/test/API/test_utils/pdb/TestPdb.py Removed: ################################################################################ diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/optional/TestDataFormatterGenericOptional.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/optional/TestDataFormatterGenericOptional.py index c88e83bb5b1f4a..3a0d241cbe7661 100644 --- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/optional/TestDataFormatterGenericOptional.py +++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/optional/TestDataFormatterGenericOptional.py @@ -6,6 +6,7 @@ class GenericOptionalDataFormatterTestCase(TestBase): TEST_WITH_PDB_DEBUG_INFO = True + SHARED_BUILD_TESTCASE = False def do_test_with_run_command(self): """Test that that file and class static variables display correctly.""" diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/shared_ptr/TestDataFormatterStdSharedPtr.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/shared_ptr/TestDataFormatterStdSharedPtr.py index fa03fc14dfb83f..cc0798f262f8dc 100644 --- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/shared_ptr/TestDataFormatterStdSharedPtr.py +++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/shared_ptr/TestDataFormatterStdSharedPtr.py @@ -10,6 +10,7 @@ class TestCase(TestBase): TEST_WITH_PDB_DEBUG_INFO = True + SHARED_BUILD_TESTCASE = False def do_test(self): """Test `frame variable` output for `std::shared_ptr` types.""" diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/span/TestDataFormatterStdSpan.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/span/TestDataFormatterStdSpan.py index 4cf447e49c8481..ada46277224902 100644 --- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/span/TestDataFormatterStdSpan.py +++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/span/TestDataFormatterStdSpan.py @@ -10,6 +10,7 @@ class StdSpanDataFormatterTestCase(TestBase): TEST_WITH_PDB_DEBUG_INFO = True + SHARED_BUILD_TESTCASE = False def findVariable(self, name): var = self.frame().FindVariable(name) diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/string_view/TestDataFormatterStdStringView.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/string_view/TestDataFormatterStdStringView.py index 8895156abb3666..ea924a0a279083 100644 --- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/string_view/TestDataFormatterStdStringView.py +++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/string_view/TestDataFormatterStdStringView.py @@ -12,6 +12,7 @@ class StdStringViewDataFormatterTestCase(TestBase): TEST_WITH_PDB_DEBUG_INFO = True + SHARED_BUILD_TESTCASE = False def setUp(self): # Call super's setUp(). diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/u8string/TestDataFormatterStdU8String.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/u8string/TestDataFormatterStdU8String.py index dda97945f9b236..9dd9ae403e16e1 100644 --- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/u8string/TestDataFormatterStdU8String.py +++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/u8string/TestDataFormatterStdU8String.py @@ -12,6 +12,7 @@ class StdU8StringDataFormatterTestCase(TestBase): TEST_WITH_PDB_DEBUG_INFO = True + SHARED_BUILD_TESTCASE = False def do_test(self): lldbutil.run_to_source_breakpoint( diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/u8string_view/TestDataFormatterStdU8StringView.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/u8string_view/TestDataFormatterStdU8StringView.py index 7eb4b1d6eebae1..50bb98b82716d2 100644 --- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/u8string_view/TestDataFormatterStdU8StringView.py +++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/u8string_view/TestDataFormatterStdU8StringView.py @@ -12,6 +12,7 @@ class StdU8StringViewDataFormatterTestCase(TestBase): TEST_WITH_PDB_DEBUG_INFO = True + SHARED_BUILD_TESTCASE = False def do_test(self): lldbutil.run_to_source_breakpoint( diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/unique_ptr/TestDataFormatterStdUniquePtr.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/unique_ptr/TestDataFormatterStdUniquePtr.py index 1516db698798d3..c0e579aa805874 100644 --- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/unique_ptr/TestDataFormatterStdUniquePtr.py +++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/unique_ptr/TestDataFormatterStdUniquePtr.py @@ -10,6 +10,7 @@ class TestCase(TestBase): TEST_WITH_PDB_DEBUG_INFO = True + SHARED_BUILD_TESTCASE = False def do_test(self): """Test `frame variable` output for `std::unique_ptr` types.""" diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/unordered/TestDataFormatterGenericUnordered.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/unordered/TestDataFormatterGenericUnordered.py index 3676c45b823f74..a1ab330b4cf347 100644 --- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/unordered/TestDataFormatterGenericUnordered.py +++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/unordered/TestDataFormatterGenericUnordered.py @@ -5,6 +5,7 @@ class GenericUnorderedDataFormatterTestCase(TestBase): TEST_WITH_PDB_DEBUG_INFO = True + SHARED_BUILD_TESTCASE = False def setUp(self): TestBase.setUp(self) diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/variant/TestDataFormatterStdVariant.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/variant/TestDataFormatterStdVariant.py index cd03c1287d25c9..c1b0bacbe4ca74 100644 --- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/variant/TestDataFormatterStdVariant.py +++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/variant/TestDataFormatterStdVariant.py @@ -10,6 +10,7 @@ class StdVariantDataFormatterTestCase(TestBase): TEST_WITH_PDB_DEBUG_INFO = True + SHARED_BUILD_TESTCASE = False def do_test(self): """Test that that file and class static variables display correctly.""" diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vector/TestDataFormatterStdVector.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vector/TestDataFormatterStdVector.py index af857d51b3d242..d589bdb6ecbfce 100644 --- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vector/TestDataFormatterStdVector.py +++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vector/TestDataFormatterStdVector.py @@ -10,6 +10,7 @@ class StdVectorDataFormatterTestCase(TestBase): TEST_WITH_PDB_DEBUG_INFO = True + SHARED_BUILD_TESTCASE = False def check_numbers(self, var_name, show_ptr=False): patterns = [] diff --git a/lldb/test/API/test_utils/pdb/TestPdb.py b/lldb/test/API/test_utils/pdb/TestPdb.py index bd3a9d0c34ab3e..7475759324a8d9 100644 --- a/lldb/test/API/test_utils/pdb/TestPdb.py +++ b/lldb/test/API/test_utils/pdb/TestPdb.py @@ -8,6 +8,7 @@ class TestBuildMethod(TestBase): TEST_WITH_PDB_DEBUG_INFO = True + SHARED_BUILD_TESTCASE = False def test(self): self.build() _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
