https://github.com/Nerixyz commented:

> It's not a good solution, I am working on a better one. This would however 
> unlock the bots while still keeping STDIN and STDOUT support in lldb.

These tests are skipped currently, right? So the bots aren't failing, they're 
only skipping. I think in this case, it would be fine if the proper fix for 
this takes some time.

>I think the correct solution would be to close the ConPTY when we receive the 
>EOF in `ConnectionGenericFile::Read`.

So it's not closed in the `ProcessWindows` destructor but in 
`ConnectionGenericFile`? Since the PTY is behind a `shared_ptr` already, could 
both `ProcessWindows` _and_ `ConnectionGenericFile` keep a reference? Then the 
PTY would be closed when both are done.

https://github.com/llvm/llvm-project/pull/182109
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to