https://github.com/Michael137 commented:
LGTM But should we have some guard-rails for people adding new tests that use `self.build(SOME_CUSTOM_PARAMETERS)` and don't realize that the build directory gets shared by default? E.g., error out if `SHARED_BUILD_TESTCASE == True` *and* the dictionary was passed explicitly? That would have some false positives but at least it won't silently do the wrong thing? https://github.com/llvm/llvm-project/pull/181720 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
