================
@@ -17,6 +17,10 @@ def: Flag<["-"], "v">,
   Alias<version>,
   HelpText<"Alias for --version">;
 
+def check_python : F<"check-python">,
+                   HelpText<"Prints the path to the resolved Python DLL. 0 if "
+                            "Python was not resolved (windows only).">;
----------------
charles-zablit wrote:

With the previous revision, there were 3 possible outputs:

- If `LLDB_PYTHON_DLL_RELATIVE_PATH` and/or 
`LLDB_PYTHON_RUNTIME_LIBRARY_FILENAME` are defined:
  - If `python.dll` is found, print the path.
  - If `python.dll` is not found, print an error.
- If none of the above defines are defined:
  - Print an empty string, as we do not know which python library to look for.

Initially, printing `0` was meant for the last scenario when none of the 
defines are defined.

> Still, is there a reason to print something other than the error string on 
> failure?

I agree, I think that the last scenario should be treated as an error and that 
if the string returned by `SetupPythonRuntimeLibrary` is empty, we should print 
an error.

With the latest changes:

- If `LLDB_PYTHON_DLL_RELATIVE_PATH` and/or 
`LLDB_PYTHON_RUNTIME_LIBRARY_FILENAME` are defined:
  - If `python.dll` is found, print the path.
  - If `python.dll` is not found, print an error.
- If none of the above defines are defined:
  - Print an error (`"unable to look for the Python shared library"`).

https://github.com/llvm/llvm-project/pull/180784
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to