llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Minsoo Choo (mchoo7) <details> <summary>Changes</summary> This is LLDB version of https://cgit.freebsd.org/ports/tree/devel/gdb/files/kgdb/arm-fbsd-kern.c. Trapframe unwinding will be implemented in future. --- Full diff: https://github.com/llvm/llvm-project/pull/180674.diff 6 Files Affected: - (modified) lldb/docs/index.rst (+1-1) - (modified) lldb/source/Plugins/Process/FreeBSDKernel/CMakeLists.txt (+1) - (added) lldb/source/Plugins/Process/FreeBSDKernel/RegisterContextFreeBSDKernel_arm.cpp (+101) - (added) lldb/source/Plugins/Process/FreeBSDKernel/RegisterContextFreeBSDKernel_arm.h (+41) - (modified) lldb/source/Plugins/Process/FreeBSDKernel/ThreadFreeBSDKernel.cpp (+6) - (modified) llvm/docs/ReleaseNotes.md (+1) ``````````diff diff --git a/lldb/docs/index.rst b/lldb/docs/index.rst index 10683c7593b01..fb5d5341b2f31 100644 --- a/lldb/docs/index.rst +++ b/lldb/docs/index.rst @@ -74,7 +74,7 @@ are welcome: * iOS, tvOS, and watchOS device debugging on ARM and AArch64 * Linux user-space debugging for i386, x86_64, ARM, AArch64, PPC64le, s390x * FreeBSD user-space debugging for i386, x86_64, ARM, AArch64, PPC -* FreeBSD kernel debugging for i386, x86_64, AArch64 +* FreeBSD kernel debugging for i386, x86_64, ARM, AArch64 * NetBSD user-space debugging for i386 and x86_64 * Windows user-space debugging for i386, x86_64, ARM and AArch64 (*) diff --git a/lldb/source/Plugins/Process/FreeBSDKernel/CMakeLists.txt b/lldb/source/Plugins/Process/FreeBSDKernel/CMakeLists.txt index c35b4def24e25..8a970a2b5dee5 100644 --- a/lldb/source/Plugins/Process/FreeBSDKernel/CMakeLists.txt +++ b/lldb/source/Plugins/Process/FreeBSDKernel/CMakeLists.txt @@ -13,6 +13,7 @@ endif() add_lldb_library(lldbPluginProcessFreeBSDKernel PLUGIN ProcessFreeBSDKernel.cpp + RegisterContextFreeBSDKernel_arm.cpp RegisterContextFreeBSDKernel_arm64.cpp RegisterContextFreeBSDKernel_i386.cpp RegisterContextFreeBSDKernel_x86_64.cpp diff --git a/lldb/source/Plugins/Process/FreeBSDKernel/RegisterContextFreeBSDKernel_arm.cpp b/lldb/source/Plugins/Process/FreeBSDKernel/RegisterContextFreeBSDKernel_arm.cpp new file mode 100644 index 0000000000000..9db4fecb9936c --- /dev/null +++ b/lldb/source/Plugins/Process/FreeBSDKernel/RegisterContextFreeBSDKernel_arm.cpp @@ -0,0 +1,101 @@ +//===-- RegisterContextFreeBSDKernel_arm.cpp ------------------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#include "RegisterContextFreeBSDKernel_arm.h" +#include "Plugins/Process/Utility/lldb-arm-register-enums.h" + +#include "lldb/Target/Process.h" +#include "lldb/Target/Thread.h" +#include "lldb/Utility/RegisterValue.h" +#include "llvm/Support/Endian.h" + +using namespace lldb; +using namespace lldb_private; + +RegisterContextFreeBSDKernel_arm::RegisterContextFreeBSDKernel_arm( + Thread &thread, std::unique_ptr<RegisterInfoPOSIX_arm> register_info_up, + lldb::addr_t pcb_addr) + : RegisterContextPOSIX_arm(thread, std::move(register_info_up)), + m_pcb_addr(pcb_addr) {} + +bool RegisterContextFreeBSDKernel_arm::ReadGPR() { return true; } + +bool RegisterContextFreeBSDKernel_arm::ReadFPR() { return true; } + +bool RegisterContextFreeBSDKernel_arm::WriteGPR() { + assert(0); + return false; +} + +bool RegisterContextFreeBSDKernel_arm::WriteFPR() { + assert(0); + return false; +} + +bool RegisterContextFreeBSDKernel_arm::ReadRegister( + const RegisterInfo *reg_info, RegisterValue &value) { + if (m_pcb_addr == LLDB_INVALID_ADDRESS) + return false; + + // https://cgit.freebsd.org/src/tree/sys/arm/include/frame.h + // struct pcb's first field is struct switchframe which is the only field used + // by debugger should be aligned by 8 bytes + struct { + llvm::support::ulittle32_t r4; + llvm::support::ulittle32_t r5; + llvm::support::ulittle32_t r6; + llvm::support::ulittle32_t r7; + llvm::support::ulittle32_t r8; + llvm::support::ulittle32_t r9; + llvm::support::ulittle32_t r10; + llvm::support::ulittle64_t r11; + llvm::support::ulittle64_t r12; + llvm::support::ulittle64_t sp; + llvm::support::ulittle64_t lr; + llvm::support::ulittle64_t pc; + } pcb; + + Status error; + size_t rd = + m_thread.GetProcess()->ReadMemory(m_pcb_addr, &pcb, sizeof(pcb), error); + if (rd != sizeof(pcb)) + return false; + + uint32_t reg = reg_info->kinds[lldb::eRegisterKindLLDB]; + switch (reg) { + +#define REG(x) \ + case gpr_##x##_arm: \ + value = pcb.x; \ + break; + + REG(r4); + REG(r5); + REG(r6); + REG(r7); + REG(r8); + REG(r9); + REG(r10); + REG(r11); + REG(r12); + REG(sp); + REG(lr); + REG(pc); + +#undef REG + + default: + return false; + } + return true; +} + +bool RegisterContextFreeBSDKernel_arm::WriteRegister( + const RegisterInfo *reg_info, const RegisterValue &value) { + return false; +} diff --git a/lldb/source/Plugins/Process/FreeBSDKernel/RegisterContextFreeBSDKernel_arm.h b/lldb/source/Plugins/Process/FreeBSDKernel/RegisterContextFreeBSDKernel_arm.h new file mode 100644 index 0000000000000..bad5688d58df3 --- /dev/null +++ b/lldb/source/Plugins/Process/FreeBSDKernel/RegisterContextFreeBSDKernel_arm.h @@ -0,0 +1,41 @@ +//===-- RegisterContextFreeBSDKernel_arm.h ----------------------*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#ifndef LLDB_SOURCE_PLUGINS_PROCESS_FREEBSDKERNEL_REGISTERCONTEXTFREEBSDKERNEL_ARM_H +#define LLDB_SOURCE_PLUGINS_PROCESS_FREEBSDKERNEL_REGISTERCONTEXTFREEBSDKERNEL_ARM_H + +#include "Plugins/Process/Utility/RegisterContextPOSIX_arm.h" +#include "Plugins/Process/elf-core/RegisterUtilities.h" + +class RegisterContextFreeBSDKernel_arm : public RegisterContextPOSIX_arm { +public: + RegisterContextFreeBSDKernel_arm( + lldb_private::Thread &thread, + std::unique_ptr<RegisterInfoPOSIX_arm> register_info_up, + lldb::addr_t pcb_addr); + + bool ReadRegister(const lldb_private::RegisterInfo *reg_info, + lldb_private::RegisterValue &value) override; + + bool WriteRegister(const lldb_private::RegisterInfo *reg_info, + const lldb_private::RegisterValue &value) override; + +protected: + bool ReadGPR() override; + + bool ReadFPR() override; + + bool WriteGPR() override; + + bool WriteFPR() override; + +private: + lldb::addr_t m_pcb_addr; +}; + +#endif // LLDB_SOURCE_PLUGINS_PROCESS_FREEBSDKERNEL_REGISTERCONTEXTFREEBSDKERNEL_ARM_H diff --git a/lldb/source/Plugins/Process/FreeBSDKernel/ThreadFreeBSDKernel.cpp b/lldb/source/Plugins/Process/FreeBSDKernel/ThreadFreeBSDKernel.cpp index dd1ed52719749..98e215146c110 100644 --- a/lldb/source/Plugins/Process/FreeBSDKernel/ThreadFreeBSDKernel.cpp +++ b/lldb/source/Plugins/Process/FreeBSDKernel/ThreadFreeBSDKernel.cpp @@ -14,8 +14,10 @@ #include "Plugins/Process/Utility/RegisterContextFreeBSD_i386.h" #include "Plugins/Process/Utility/RegisterContextFreeBSD_x86_64.h" +#include "Plugins/Process/Utility/RegisterInfoPOSIX_arm.h" #include "Plugins/Process/Utility/RegisterInfoPOSIX_arm64.h" #include "ProcessFreeBSDKernel.h" +#include "RegisterContextFreeBSDKernel_arm.h" #include "RegisterContextFreeBSDKernel_arm64.h" #include "RegisterContextFreeBSDKernel_i386.h" #include "RegisterContextFreeBSDKernel_x86_64.h" @@ -62,6 +64,10 @@ ThreadFreeBSDKernel::CreateRegisterContextForFrame(StackFrame *frame) { *this, std::make_unique<RegisterInfoPOSIX_arm64>(arch, 0), m_pcb_addr); break; + case llvm::Triple::arm: + m_thread_reg_ctx_sp = std::make_shared<RegisterContextFreeBSDKernel_arm>( + *this, std::make_unique<RegisterInfoPOSIX_arm>(arch), m_pcb_addr); + break; case llvm::Triple::x86: m_thread_reg_ctx_sp = std::make_shared<RegisterContextFreeBSDKernel_i386>( *this, new RegisterContextFreeBSD_i386(arch), m_pcb_addr); diff --git a/llvm/docs/ReleaseNotes.md b/llvm/docs/ReleaseNotes.md index 30e74acf973ed..a245f3deb1812 100644 --- a/llvm/docs/ReleaseNotes.md +++ b/llvm/docs/ReleaseNotes.md @@ -182,6 +182,7 @@ Changes to LLDB * Support for FreeBSD on MIPS64 has been removed. * The minimum assumed version of FreeBSD is now 14. The effect of which is that watchpoints are assumed to be supported. +* Kernel debugging support for ARM on FreeBSD has been added. Changes to BOLT --------------- `````````` </details> https://github.com/llvm/llvm-project/pull/180674 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
