emaste wrote: Based on the test that was here `#if __FreeBSD_version >= 1300139` it seems like the watchpoint support should be available as of FreeBSD 13; at least, we'll try to use the watchpoint code for FreeBSD 13.0 and later so this change will only affect 12.x and earlier. Based on that this LGTM.
I've been chatting with @mchoo7 on a FreeBSD IRC channel and we discussed whether this pull request should be updated to reference 13 instead of 14. I think it's fine to leave as is -- LLDB may well continue to work on FreeBSD 13.x but after it is EOL people in the FreeBSD+LLDB community aren't going to be interested in testing/debugging issues, and claiming that LLDB supports 14 and later makes sense to me. For background: I have no concerns with MIPS being removed coincident with the EOL of 13.x as MIPS was not tier-1 and not widely used. For things relating to support of Tier-1 platforms (amd64, arm64) where it's easy to do so I'd rather keep code around for some period of time after the FreeBSD release is EOL. Some FreeBSD downstreams build on forks of specific releases that they keep using after FreeBSD stops supporting it. https://github.com/llvm/llvm-project/pull/179587 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
