llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Priyanshu Kumar (Priyanshu3820) <details> <summary>Changes</summary> The method claims to check if a is a subset of b, but the implementation `a | b ==a` actually checks if b is a subset of a. This patch fixes that. --- Full diff: https://github.com/llvm/llvm-project/pull/179873.diff 1 Files Affected: - (modified) lldb/test/API/tools/lldb-dap/stopped-events/TestDAP_stopped_events.py (+1-1) ``````````diff diff --git a/lldb/test/API/tools/lldb-dap/stopped-events/TestDAP_stopped_events.py b/lldb/test/API/tools/lldb-dap/stopped-events/TestDAP_stopped_events.py index 03dff39c82ed9..06d58fc6ff97d 100644 --- a/lldb/test/API/tools/lldb-dap/stopped-events/TestDAP_stopped_events.py +++ b/lldb/test/API/tools/lldb-dap/stopped-events/TestDAP_stopped_events.py @@ -16,7 +16,7 @@ class TestDAP_stopped_events(lldbdap_testcase.DAPTestCaseBase): def matches(self, a: dict, b: dict) -> bool: """Returns true if 'a' is a subset of 'b', otherwise false.""" - return a | b == a + return b | a == b def verify_threads(self, expected_threads): threads_resp = self.dap_server.request_threads() `````````` </details> https://github.com/llvm/llvm-project/pull/179873 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
