================
@@ -323,8 +323,16 @@ bool JITLoaderGDB::ReadJITDescriptorImpl(bool all_entries)
{
char jit_name[64];
snprintf(jit_name, 64, "JIT(0x%" PRIx64 ")", symbolfile_addr);
- module_sp = m_process->ReadModuleFromMemory(
- FileSpec(jit_name), symbolfile_addr, symbolfile_size);
+ llvm::Expected<ModuleSP> module_sp_or_err =
+ m_process->ReadModuleFromMemory(FileSpec(jit_name), symbolfile_addr,
+ symbolfile_size);
+ if (auto err = module_sp_or_err.takeError())
+ LLDB_LOG_ERROR(
+ log, std::move(err),
+ "JITLoaderGDB::{1} failed to read module from memory: {0}",
+ __FUNCTION__);
----------------
Michael137 wrote:
You use `__FUNCTION__` here but not in the other places that you log the name
of the function. Is that just being consistent with the rest of the file?
https://github.com/llvm/llvm-project/pull/179583
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
