jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land.
Looks fine to me, I don't know the debug_types sections that you're supporting but I read over the code and don't have any problems. ================ Comment at: source/Plugins/SymbolFile/DWARF/DWARFDIE.h:92 + // .debug_info or the .debug_types section so anyone extracting data from + // a DIE must use the correct data. + // ---------------- DWARFDIE::GetData() handles the difference between debug_info / debug_types so the callers of this method don't need to worry about that, correct? Maybe the comment could say // Get the data that contains the attribute values for this DIE. Support // for .debug_types means that any DIE can have its data either in the // .debug_info or the .debug_types section; this method will return the // correct section data. or something. https://reviews.llvm.org/D32167 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
