https://github.com/jimingham commented:
My general rule is "If there's substantial code in an SB interface beyond marshaling input and constructing the result it's in the wrong place." So this change is fine structurally. Either explain why you needed to friend ScriptInterpreter in this patch or remove that bit and this is good to go. https://github.com/llvm/llvm-project/pull/178568 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
