labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
Thank you for taking the time to do this. It looks like ppoll was added to linux quite a long time ago, but we still get some patches supporting surprisingly old kernels. I hope it doesn't come do that, but if it does, we can easily add a pselect-based fallback as well. looks good, assuming that the SYS_EVENT_H define can go away. ================ Comment at: source/Host/common/MainLoop.cpp:22 +#undef HAVE_SYS_EVENT_H +#define HAVE_SYS_EVENT_H 0 + ---------------- This looks wrong. Is this left over from testing ? ================ Comment at: source/Host/common/MainLoop.cpp:241 + auto it = m_read_fds.find(event_list[i].ident); + if (it == m_read_fds.end()) + continue; ---------------- Nit: the if could be extracted out of the `#ifdef` https://reviews.llvm.org/D31823 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
