JDevlieghere wrote:

This sounds neat. We've always missed a console in the TUI (primarily because 
editline and ncurses don't play nice together) but that shouldn't preclude 
having a console area with output from the inferior.

A few high level comments:

1. This needs a test. Please take a look at the 
`llvm-project/lldb/test/API/commands/gui` subdirectory for inspiration.
2. Please take a look at the [LLVM Coding 
Standards](https://llvm.org/docs/CodingStandards.html). For example, no braces 
after single line if's and comments should be English prose with capitalization 
and a period. 

https://github.com/llvm/llvm-project/pull/177010
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to