jimingham wrote: This commit is asserting that TargetList::CreateTargetInternal can (and should) be called without holding the TargetList mutex. I didn't explore this in depth, but from a quick look that seems to be true. So that part seems fine.
But documenting that requirement in the calls to CreateTargetInternal in the CreateTarget factory seems wrong. Instead, you want to have a comment where CreateTargetInternal is defined saying "Don't hold the target list mutex when calling this function". Then anybody else who might come to use the method will know how to do it right. https://github.com/llvm/llvm-project/pull/168425 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
