https://github.com/jimingham approved this pull request.

This LGTM except for a suggested change in the comment for m_frame_list_wp.  
You make it sound like this is some optional thing that you could choose to use 
or not.  But if it is resolveable it IS the stack frame list in which you are 
supposed to look up m_stack_id.  Your comment needs to say that.
Approved provided the comment is fixed.

https://github.com/llvm/llvm-project/pull/170226
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to