labath added a comment.

I like the idea of adding boilerplate first, so that we can than better focus 
on the important stuff later. However, I think you've have gone a bit too far 
with it -- you introduce a lot of functions I am pretty sure will not be 
necessary for your case, or that should be handled differently (software single 
stepping stuff, handling of linux thread stopping, ...).

Could we trim this down to just the functions that are necessary to get this 
building (basically just virtual overrides -- no private functions or members)? 
Those can be always added along with the patch that implements them, and then 
we will be in a better position to review it.


Repository:
  rL LLVM

https://reviews.llvm.org/D31138



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to