krytarowski added inline comments.
================
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:588
+ }
+ } else if (strncmp(note.n_name.c_str(), "OpenBSD", 7) == 0) {
+ m_os = llvm::Triple::OpenBSD;
----------------
kettenis wrote:
> krytarowski wrote:
> > `note.n_name == "OpenBSD"` ?
> That wouldn't work. The notes describing the registers have the thread ID
> attached to this name, i.e. "OpenBSD@250037". I'll need to parse that string
> to make core dumps of multi-threaded processes work later.
I would change it o `string::substr` to make it more clear that it's not just
secure comparison of a string. A comment explaining it for those not familiar
with OpenBSD internals would be nice.
Repository:
rL LLVM
https://reviews.llvm.org/D31131
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
