zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Looks great.
================
Comment at: tools/lldb-server/LLDBServerUtilities.cpp:59-60
if (!success) {
- fprintf(stderr, "Unable to open log file '%s' for channel \"%s\"\n",
- log_file.c_str(), channel_with_categories.str().c_str());
+ fprintf(stderr, "Unable to setup logging for channel \"%s\": %s",
+ channel.c_str(), error_stream.str().c_str());
return false;
----------------
How about `llvm::errs() << formatv("Unable to setup logging for channel
\"{0}\": {1}\n", channel, error_stream.str());`
https://reviews.llvm.org/D30894
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
