https://github.com/JDevlieghere approved this pull request.
The change LGTM, but it makes me wonder if we should adopt unblocking reads like we do in JSONTransport. We already have a thread queueing up ProtocolMessages, so maybe it's time to double down on that and prevent anyone from doing a blocking read directly? That would also help with the randomized delay idea I posted yesterday (where we could add the messages to the queue after a random amount of time to simulate slow CI nodes and non-deterministic ordering between request/responses and events). https://github.com/llvm/llvm-project/pull/165823 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
