================
@@ -814,13 +814,17 @@ DWARFASTParserClang::ParseTypeModifier(const
SymbolContext &sc,
// there...
[[fallthrough]];
- case DW_TAG_base_type:
+ case DW_TAG_base_type: {
resolve_state = Type::ResolveState::Full;
+ // If a builtin type's size isn't a multiple of a byte, DWARF producers may
+ // add a precise bit-size to the type. Use the most precise bit-size
+ // possible.
+ uint64_t bit_size = attrs.data_bit_size ? *attrs.data_bit_size
----------------
Michael137 wrote:
Every time I try to make a local variable const I get push-back saying that's
not LLVM-style. Though I couldn't find any such statements in the style guide.
I think the reasoning for avoiding `const` is that it then makes the reader
question, "why isn't that other variable const". By that logic, if we wanted
`const` local variables, we'd have to do them in bulk for the entire function.
I'm not sure where I stand on that, I think I prefer making new variables const
when possible 🤷♂️
But I agree with you that these particular cases have a small enough scope that
`const` should be uncontroversial.
https://github.com/llvm/llvm-project/pull/165689
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
