lgtm On Wed, Mar 1, 2017 at 4:26 PM Jason Majors via Phabricator via lldb-commits <lldb-commits@lists.llvm.org> wrote:
> jmajors created this revision. > > It does not change members or call non-const members. > HostInfo::GetArchitecture() returns a const object ref (maybe others?), > which can't access the non-const function. > > > https://reviews.llvm.org/D30515 > > Files: > include/lldb/Core/ArchSpec.h > source/Core/ArchSpec.cpp > > > Index: source/Core/ArchSpec.cpp > =================================================================== > --- source/Core/ArchSpec.cpp > +++ source/Core/ArchSpec.cpp > @@ -657,7 +657,7 @@ > SetFlags(flag); > } > > -std::string ArchSpec::GetClangTargetCPU() { > +std::string ArchSpec::GetClangTargetCPU() const { > std::string cpu; > const llvm::Triple::ArchType machine = GetMachine(); > > Index: include/lldb/Core/ArchSpec.h > =================================================================== > --- include/lldb/Core/ArchSpec.h > +++ include/lldb/Core/ArchSpec.h > @@ -307,7 +307,7 @@ > /// @return A string representing target CPU for the current > /// architecture. > //------------------------------------------------------------------ > - std::string GetClangTargetCPU(); > + std::string GetClangTargetCPU() const; > > //------------------------------------------------------------------ > /// Return a string representing target application ABI. > > > _______________________________________________ > lldb-commits mailing list > lldb-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
