JDevlieghere wrote:

> How will this be tested? We can run API tests on iOS, right? I get that only 
> you at Apple are likely to be able to do that with any convenience, but still.
>
> Also you'd probably save a bunch of time by doing one giant test that checks 
> all the little MTE additions in one go, maybe that is in fact your plan.

Yeah, that was indeed my plan. Downstream this was implemented before we had 
hardware so at the time I wrote a test that uses an emulator (which isn't 
available publicly). Given that, as you said, only we can run the on-device 
test suite, I figured it wouldn't add much value to add a small test for this 
change at this time. We have some more changes in the pipeline (including from 
@yln) that have more comprehensive testing, so we can do one big MTE test once 
all the pieces land if that's okay with you. 

https://github.com/llvm/llvm-project/pull/159117
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to