charles-zablit wrote:

> LLDB reviewer here, I am not very familiar with Python typing but -
> 
> > We from **future** import annotations at the start of cindex.py which lets 
> > us use the PEP 585 features (among others) even in Pyhon 3.8.
> 
> Can we do this in the lldb file as well? When the minimum becomes whatever it 
> needs to be to remove that statement, it'll be easy to find.
> 
> Also change the title tag to `[lldb]`.

Switched to the `import from __future__` approach. Using `list` instead of 
`List` has been common practice for a while. As you said, we can remove the 
annotation once we drop support for 3.8.

https://github.com/llvm/llvm-project/pull/156868
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to