JDevlieghere wrote: Can you talk a bit about what's motivating this change? I'm a little worried about the proliferation of new options and I'm especially wary about the ones that need to be specified on the command line instead of over the protocol. Every new option extends the matrix of things we need to support.
- Can this be a UI setting instead of a command line option? - Milliseconds seems like the wrong granularity for this . Seconds or minutes seems like a more meaningful order of magnitude. - This definitely needs a test. Unfortunately, tests that rely on timing tend to be less reliable, but here there should be a lower bound (e.g. exceeds X seconds) rather than an upper bound, so hopefully that should be fine. https://github.com/llvm/llvm-project/pull/156803 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
