jimingham wrote:

The only bad effect I can see just from looking at the patch is if I had 
selected frame 5 of a given thread, and then had run an expression.  I want to 
make sure that when the expression is done running, we don't set the selected 
frame back to 0 (or whatever the most relevant frame machinery would choose).  
It should stay at 5.  I am pretty sure that will work because the expression 
evaluator resets the frame by hand when it's done.  
But we should make sure I'm right about that.
Other than that, this still seems fine to me.

https://github.com/llvm/llvm-project/pull/133078
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to