Nerixyz wrote:

> It completes the element type.

As in, "if an array type is encountered, it's immediately completed"? Because 
in native PDB (with this PR too), it would be delayed.

> Is there a place in the PDB plugin where we can do the same thing we do for 
> DWARF?

Yes, in `PdbAstBuilder::createArrayType` a `CompleteType(element_type)` could 
be added, and the test would pass too:
https://github.com/llvm/llvm-project/blob/74b9484fd62d6be9bc49e154800ceef0d74ef24f/lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp#L1170-L1172

Would this be a better place?

https://github.com/llvm/llvm-project/pull/156370
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to