Author: nerix Date: 2025-08-14T14:23:39+01:00 New Revision: 7bda76367f19cfc19086f68d9dd5ac019a9ceccd
URL: https://github.com/llvm/llvm-project/commit/7bda76367f19cfc19086f68d9dd5ac019a9ceccd DIFF: https://github.com/llvm/llvm-project/commit/7bda76367f19cfc19086f68d9dd5ac019a9ceccd.diff LOG: [LLDB][NativePDB] Ignore functions with no type in name lookup (#153382) Some functions don't have the `FunctionType` set. We can't look these up and won't be able to call them, so ignore them when caching the function names. This does fix the failures caused by https://github.com/llvm/llvm-project/pull/153160 mentioned in https://github.com/llvm/llvm-project/pull/153160#issuecomment-3183062431. However, in `lldb-shell::msstl_smoke.cpp` there's another failure not introduced by #153160 (fixed with #153386). Added: Modified: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp Removed: ################################################################################ diff --git a/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp b/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp index 108e439317b76..112eb06e462fc 100644 --- a/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp +++ b/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp @@ -1688,7 +1688,7 @@ void SymbolFileNativePDB::CacheFunctionNames() { llvm::cantFail(SymbolDeserializer::deserializeAs<ProcSym>(*iter)); if ((proc.Flags & ProcSymFlags::IsUnreachable) != ProcSymFlags::None) continue; - if (proc.Name.empty()) + if (proc.Name.empty() || proc.FunctionType.isSimple()) continue; // The function/procedure symbol only contains the demangled name. _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
