https://github.com/jimingham requested changes to this pull request.

At the site where you are fixing this, this is a workaround of a workaround, so 
I don't so much mind that.  

But you shouldn't be mentioning a specific language in a TypeSystem method, so 
I don't like the IsCXXClassType.  IsClassTypeForLanguage would be okay, but not 
IsCXXClassType.

https://github.com/llvm/llvm-project/pull/153454
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to