https://github.com/JDevlieghere commented:
I left a few more comments. I'm generally very wary of passing shared pointers by const ref. It's especially dangerous when they get removed from lists, which is exactly what this patch is doing. It's a big foot gun that I would normally push back on, but I realize that (1) the refcount is what this patch is relying on to remove the modules and (2) that this is a performance optimization so maybe the overhead of synchronizing the refcount would matter. https://github.com/llvm/llvm-project/pull/152607 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
