================
@@ -804,6 +804,13 @@ def setUpCommands(cls):
)
return commands
+ def getDebugInfoSetupCommands(self):
+ if self.getDebugInfo() == "native-pdb":
----------------
labath wrote:
I don't know that for sure, but I can imagine it being added just because the
function didn't need the instance argument at the time. It may be possible to
remove it.
That said, I'm not entirely happy with how these new categories are are
behaving quite differently from the other debug info categories. The other
categories change the kind of debug info that's being emitted -- not which code
is parsing that debug info.
Having a `pdb` category to get clang to produce pdb debug info makes perfect
sense. I'm not so sure about using that category to select the plugin kind --
particularly if the end goal is to remove the non-native plugin completely.
When I made the suggestion to use settings I was imagining you would be setting
it on a per-run basis via the `--setting` flag to dotest.py. Would that be an
option?
https://github.com/llvm/llvm-project/pull/149305
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
