Geoff asked for this to be merged to 4.0. It looks like a nice change, but I'm a little hesitant since it doesn't look like it's fixing a regression. Pavel, what do you think?
On Fri, Feb 3, 2017 at 9:42 AM, Pavel Labath via lldb-commits <lldb-commits@lists.llvm.org> wrote: > Author: labath > Date: Fri Feb 3 11:42:04 2017 > New Revision: 294019 > > URL: http://llvm.org/viewvc/llvm-project?rev=294019&view=rev > Log: > Push down more common code into PlatformPOSIX > > Summary: > - GetFileWithUUID: All platforms except PlatformDarwin had this. > However, I see no reason why this code would not apply there as well. > > - GetProcessInfo, FindProcesses: The implementation was the same in all > classes. > > - GetFullNameForDylib: This code should apply to all non-darwin > platforms. I've kept the PlatformDarwin override as the situation is > different there. > > Reviewers: clayborg, krytarowski, emaste > > Subscribers: lldb-commits > > Differential Revision: https://reviews.llvm.org/D29496 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
