https://github.com/labath commented:
The code looks good, but I have a problem with the docstring, as it captures none of the subtlety around this function (which was discussed in the other thread). I'd recommend something like: "If this Module represents a part of a larger file, returns the name of that part. Otherwise, returns nullptr." The test is also pretty weak. Basically, all it does is verify that the result is a string. I'd suggest looking at TestBSDArchives.py. I think it should be fairly easy to extend that to cover this function as well -- just take one of the SBModuleSpecs floating around and use that to create SBModule (then call this function). https://github.com/llvm/llvm-project/pull/150331 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
